Skip to content

fix: building without the system tray enabled#5092

Merged
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
chewi:no-tray
May 11, 2026
Merged

fix: building without the system tray enabled#5092
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
chewi:no-tray

Conversation

@chewi
Copy link
Copy Markdown
Contributor

@chewi chewi commented May 10, 2026

Description

Without this, the build currently fails with undefined references to system_tray::end_tray when giving -DSUNSHINE_ENABLE_TRAY=no.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Bundle Report

Bundle size has no change ✅

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.85%. Comparing base (0db9f73) to head (aa8428b).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5092      +/-   ##
==========================================
- Coverage   17.86%   17.85%   -0.01%     
==========================================
  Files         111      111              
  Lines       24005    24005              
  Branches    10619    10619              
==========================================
- Hits         4289     4287       -2     
+ Misses      16670    15502    -1168     
- Partials     3046     4216    +1170     
Flag Coverage Δ
Archlinux 11.23% <ø> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.37% <ø> (+0.01%) ⬆️
Homebrew-ubuntu-22.04 13.58% <ø> (ø)
Linux-AppImage 12.16% <ø> (ø)
Windows-AMD64 14.84% <ø> (ø)
Windows-ARM64 13.24% <ø> (+<0.01%) ⬆️
macOS-arm64 19.03% <ø> (ø)
macOS-x86_64 18.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 73 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0db9f73...aa8428b. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit 676d331 into LizardByte:master May 11, 2026
127 of 129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants